-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to ignore some controller by Kind #710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Adding a new flag will require end-to-end tests for this flag at a minimum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally got a chance to look more closely at this, and there's some things that need to be corrected to match other patterns in the code where we pass settings via the reconciler.
Co-authored-by: Andy Suderman <andy@suderman.dev>
Co-authored-by: Andy Suderman <andy@suderman.dev>
Co-authored-by: Andy Suderman <andy@suderman.dev>
Co-authored-by: Andy Suderman <andy@suderman.dev>
Hi @sudermanjr, Thanks a lot for the suggestions. I merged them. Sorry again for my poor coding skills. |
…gets declared on line 49
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks!
This PR fixes #534
Checklist
Description
prevent VPA creation for Cronjob or Job controller kinds
What changes did you make?
adding a new arg
--ignore-controller-kind=Job,CronJob
that prevents certain controller kinds from being consideredWhat alternative solution should we consider, if any?
notes
I am sorry that I am not following your contribution guidelines. I am not a developer and was using GitHub Copilot to make these changes. The
make tidy
andmake build
are compiling without any errors - I have only limited resources and permissions on my works laptop. I would be grateful if you would still consider this improvement.