Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INSIGHTS-157 - PDB <> HPA check #1057

Merged
merged 23 commits into from
Jul 8, 2024
Merged

INSIGHTS-157 - PDB <> HPA check #1057

merged 23 commits into from
Jul 8, 2024

Conversation

vitorvezani
Copy link
Member

This PR fixes #

Checklist

  • I have signed the CLA
  • I have updated/added any relevant documentation

Description

What's the goal of this PR?

What changes did you make?

What alternative solution should we consider, if any?

@fairwinds-insights Fairwinds Insights
Copy link

Fairwinds Insights Scan Results

View the full report at insights.fairwinds.com.

✅ No new Action Items detected!

@vitorvezani vitorvezani changed the title [WIP] INSIGHTS-157 - PDB <> HPA check INSIGHTS-157 - PDB <> HPA check Jul 1, 2024
sudermanjr
sudermanjr requested changes Jul 3, 2024
View reviewed changes
Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am realizing that this should probably be that pdb.MinAvailable < hpa.MinReplicas (non-inclusive) - this makes it so that you allow 1 disrupted pod at minimum, which is the goal.

docs/checks/reliability.md Outdated Show resolved Hide resolved
test/checks/pdbMinAvailableGreaterThanHPAMinReplicas/failure-gt-percent.yaml Show resolved Hide resolved
test/checks/pdbMinAvailableGreaterThanHPAMinReplicas/failure-gt-percent.yaml Outdated Show resolved Hide resolved
vitorvezani and others added 2 commits July 3, 2024 15:00
@vitorvezani @sudermanjr
Update docs/checks/reliability.md
a53a236 
Co-authored-by: Andy Suderman <andy@fairwinds.com>
@vitorvezani
fix/add tests
29d8f74
@vitorvezani vitorvezani merged commit 952b6ae into master Jul 8, 2024
7 checks passed
@vitorvezani vitorvezani deleted the pdb-hpa/vv/INSIGHTS-157 branch July 8, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudermanjr sudermanjr sudermanjr approved these changes

@rbren rbren Awaiting requested review from rbren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitorvezani @sudermanjr