add ability to audit a single workload #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbren
requested review from
baderbuddy,
jordandoig and
makoscafee
as code owners
Codecov Report
@@ Coverage Diff @@
## master #368 +/- ##
==========================================
- Coverage 53.55% 48.27% -5.28%
==========================================
Files 12 12
Lines 732 812 +80
==========================================
Hits 392 392
- Misses 285 365 +80
Partials 55 55
Continue to review full report at Codecov.
|
baderbuddy
reviewed
Jul 1, 2020
|
|
||
| parts := strings.Split(workload, "/") | ||
| if len(parts) != 4 { | ||
| return nil, fmt.Errorf("Invalid workload identifier %s. Should be in format namespace/kind/version/name, e.g. nginx-ingress/Deployment.apps/v1/default-backend", workload) |
There was a problem hiding this comment.
In the help text you ask for 3 pieces (namespace/kind/name) instead of including version.
rbren
force-pushed
the
rb/single-workload
branch
from
79cdb9d to
38a9ba6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly I haven't been able to test this - I can't get DynamicClient to work properly in test mode. Any ideas would be appreciated.