Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.yaml #378

Merged
merged 3 commits into from
Jul 22, 2020
Merged

Update config.yaml #378

merged 3 commits into from
Jul 22, 2020

Conversation

rbren
Copy link
Contributor

@rbren rbren commented Jul 21, 2020

No description provided.

Copy link
Contributor

@baderbuddy baderbuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@makoscafee makoscafee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...
just not sure why pull policy should always be Always

@baderbuddy
Copy link
Contributor

I was curious if we had documentation for our users in case anyone else was confused about why to set image pull policy to always. I found this. https://github.com/FairwindsOps/polaris/blob/master/docs/check-documentation/images.md

It explicitly states that we don't enable this by default. I still feel like it should be enabled but maybe we should update that doc too.

@rbren rbren merged commit 4e290e1 into master Jul 22, 2020
@rbren rbren deleted the rb/pull-policy branch July 22, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants