Install Doc Updates #451
Merged
Install Doc Updates #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected name of helm repo for polaris chart and added blurb about requiring TLS certs.
Updated to reflect the kubectl and helm install methods both require cert-manager.
jlwynkoop
requested review from
baderbuddy,
jordandoig,
makoscafee and
rbren
as code owners
|
|
rbren
approved these changes
Dec 16, 2020
rbren
reviewed
Dec 16, 2020
docs-md/admission-controller.md
Outdated
|
|
||
| Supply a CA Bundle with the webhook.caBundle | ||
| Create a TLS secret in your cluster with a valid certificate that uses that CA | ||
| Pass the name of that secret with the webhook.secretName parameter. |
There was a problem hiding this comment.
Can you add a * in front of these to bullet them? Looks like they get squished together currently.
There was a problem hiding this comment.
Done, thanks for catching that.
Adding bullets to the steps required for CA bundle use.
Fixed typo in the chart URL
makoscafee
approved these changes
Dec 16, 2020
|
|
||
| * Supply a CA Bundle with the webhook.caBundle | ||
| * Create a TLS secret in your cluster with a valid certificate that uses that CA | ||
| * Pass the name of that secret with the webhook.secretName parameter. |
There was a problem hiding this comment.
Suggested change
| * Pass the name of that secret with the webhook.secretName parameter. | |
| * Pass the name of that secret with the `webhook.secretName` parameter. |
There was a problem hiding this comment.
By the way, this will only apply for helm installation option, right? not sure how to rephrase this for kubectl option..
Co-authored-by: Barnabas Makonda <6409210+makoscafee@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommend updating the install document to be more clear about the use of cert-manager and also updating the name of the helm chart repository to reflect "fairwinds" rather than "fairwindsOps".