Fix test fixtures, add a test for controllers #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbren
requested review from
baderbuddy,
jordandoig and
makoscafee
as code owners
rbren
force-pushed
the
rb/test-fixtures
branch
from
738c901 to
ce60411
Compare
baderbuddy
approved these changes
Dec 17, 2020
pkg/kube/resources_test.go
Outdated
| namespaceCount := map[string]int{} | ||
| for _, controller := range resources.Controllers { | ||
| namespaceCount[controller.ObjectMeta.GetNamespace()]++ | ||
| } | ||
| assert.Equal(t, 7, namespaceCount[""], "Should have seven controller in default namespace") | ||
| assert.Equal(t, 8, namespaceCount[""], "Should have seven controller in default namespace") |
There was a problem hiding this comment.
Maybe we should get rid of these messages, both of them are out of sync now.
| "daemonset": false, | ||
| } | ||
| for _, ctrl := range resources.Controllers { | ||
| expectedNames[ctrl.ObjectMeta.GetName()] = true |
There was a problem hiding this comment.
I like this way of handling. I wonder if the assert library we use has something built in already or if we could contribute to it
There was a problem hiding this comment.
I think there's something like it, but it expects the same object type
Codecov Report
@@ Coverage Diff @@
## master #455 +/- ##
==========================================
+ Coverage 45.85% 48.14% +2.28%
==========================================
Files 12 12
Lines 700 700
==========================================
+ Hits 321 337 +16
+ Misses 325 302 -23
- Partials 54 61 +7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.