Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ingress objects #469

Merged
merged 16 commits into from
Jan 14, 2021
Merged

Add support for ingress objects #469

merged 16 commits into from
Jan 14, 2021

Conversation

jordandoig
Copy link
Contributor

@jordandoig jordandoig commented Jan 4, 2021

This PR adds support for checking Ingress kubernetes objects

Copy link
Contributor

@rbren rbren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking awesome! LMK if you want to chat through the frontend changes at all.

pkg/validator/schema.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #469 (93a80e4) into master (ec557f7) will decrease coverage by 0.21%.
The diff coverage is 55.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
- Coverage   49.01%   48.80%   -0.22%     
==========================================
  Files          12       13       +1     
  Lines         712      754      +42     
==========================================
+ Hits          349      368      +19     
- Misses        302      317      +15     
- Partials       61       69       +8     
Impacted Files Coverage Δ
pkg/config/schema.go 11.59% <ø> (ø)
pkg/kube/resources.go 42.56% <22.22%> (-1.53%) ⬇️
pkg/validator/summary.go 42.68% <33.33%> (+0.18%) ⬆️
pkg/validator/controller.go 74.07% <60.00%> (ø)
pkg/validator/ingress.go 60.00% <60.00%> (ø)
pkg/validator/fullaudit.go 51.16% <66.66%> (+1.16%) ⬆️
pkg/validator/schema.go 70.90% <68.42%> (-2.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec557f7...93a80e4. Read the comment docs.

Copy link
Contributor

@rbren rbren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Seems to be a bug when running locally though - I think we need to check if PodResult != nil in a few places.

To test locally, you can run:

kubectl create ns polaris
helm upgrade --install polaris fairwinds-stable/polaris --set dashboard.ingress.enabled=true -n polaris --set dashboard.ingress.hosts[0]="foo.bar.com"
go run main.go dashboard

Probably worth adding a test case to the webhook tests as well

@jordandoig jordandoig merged commit a8e9016 into master Jan 14, 2021
@jordandoig jordandoig deleted the jd/out-of-control branch January 14, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants