-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ingress objects #469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking awesome! LMK if you want to chat through the frontend changes at all.
Codecov Report
@@ Coverage Diff @@
## master #469 +/- ##
==========================================
- Coverage 49.01% 48.80% -0.22%
==========================================
Files 12 13 +1
Lines 712 754 +42
==========================================
+ Hits 349 368 +19
- Misses 302 317 +15
- Partials 61 69 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Seems to be a bug when running locally though - I think we need to check if PodResult != nil
in a few places.
To test locally, you can run:
kubectl create ns polaris
helm upgrade --install polaris fairwinds-stable/polaris --set dashboard.ingress.enabled=true -n polaris --set dashboard.ingress.hosts[0]="foo.bar.com"
go run main.go dashboard
Probably worth adding a test case to the webhook tests as well
This PR adds support for checking Ingress kubernetes objects