Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes for NSA checks #952

Merged
merged 6 commits into from
Jun 9, 2023
Merged

Minor fixes for NSA checks #952

merged 6 commits into from
Jun 9, 2023

Conversation

rbren
Copy link
Contributor

@rbren rbren commented Jun 7, 2023

This PR fixes a couple minor issues when scanning IaC with the new checks

Checklist

  • I have signed the CLA
  • I have updated/added any relevant documentation

Description

What's the goal of this PR?

What changes did you make?

What alternative solution should we consider, if any?

@rbren rbren requested a review from mggude as a code owner June 7, 2023 18:46
@fairwinds-insights
Copy link

Fairwinds Insights CI Report

View the Full Report

✅ No new Action Items detected!

@sudermanjr
Copy link
Member

Fixes #953

Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mggude mggude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sudermanjr sudermanjr merged commit 8bfed75 into master Jun 9, 2023
@sudermanjr sudermanjr deleted the rb/fix-rbac-checks branch June 9, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants