Fix nil pointer issue with webhook #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fairwinds Insights CI Report✅ No new Action Items detected! |
rbren
changed the title
rbren
changed the title
jdesouza
approved these changes
Jun 22, 2023
jdesouza
reviewed
Jun 22, 2023
| @@ -161,8 +161,6 @@ workflows: | |||
| only: /.*/ | |||
| - build_and_push: | |||
| context: org-global | |||
| requires: | |||
There was a problem hiding this comment.
Was that intentional to remove the test?
There was a problem hiding this comment.
Yeah I don't think it's necessary.
There was a problem hiding this comment.
tests still run--they just don't block building the docker image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hopefully fixes a
panicin the admission controllerChecklist
Description
What's the goal of this PR?
Some users report a
nil pointerpanic when running the webhook as of 8.2What changes did you make?
What alternative solution should we consider, if any?