Fix #148 #165
Merged
Fix #148 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thw26
force-pushed
the
148-wine-version-check-update
branch
5 times, most recently
from
0f9939b
to
57f2aed
Compare
thw26
force-pushed
the
148-wine-version-check-update
branch
from
57f2aed
to
e9693a4
Compare
thw26
force-pushed
the
148-wine-version-check-update
branch
from
e9693a4
to
3cc21d3
Compare
n8marti
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #148. My goal is to make the code more readable/usable/extensible (for future wine versions).
The goal was to get rid of the lengthy if/else check. Short of just keeping a list of known bad versions for x.0–x.26, I thought a rules based approach would be better, i.e., making what was explicit is now contained in a reusable function.
I haven not noticed any regressions with this change.