Incorporate Unit testing #89
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can drop eff4d99. |
|
dropped redundant commit, rebased on current |
n8marti
force-pushed
the
unittests
branch
3 times, most recently
from
1da0f81
to
ffb1e6c
Compare
initial coverage and unittest additions initial commit for test_utils.py initial commit for test_msg.py & .coverage add test_LLI.py & update coverage add intentionally-failing test backup file require successful tests before building the binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit testing is intended to ensure expected behavior for individual functions. It's not intended to ensure expected behavior of large components or main functionality of the app/script, which would be considered integration testing. But the addition of unit testing should help prevent future bugs.
However, to be effective, new tests would need to be written for any new functions. We can discuss how this might work out in practice.
I've added a command to run the unit tests in the build script and abort the build if the unit tests fail. I think this is a good idea in theory. We'll have to see how it works out in practice.
Unit tests can be run locally if you
pip install coverage, then runpython -m coverage run -m unittest -b -v. Note: I had to re-build python 3.12 on my system because my original build didn't include ansqlitemodule needed bycoverage. So theensure-python.shscript has been modified to make this work correctly.