-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix greek phone numbers #16
Conversation
Can we add some PHPDoc in the new methods? I know its not there everywhere but it will help us future wise a lot |
@pimjansen I've added return types as well as docblocks with descriptions and examples. |
@sebdesign, you introduced a breaking change by setting up the return types. |
Ah, you're right, I removed them now. |
@pimjansen BC check is still squawking because i changed some methods from static to non-static. I suppose this is not an issue, because the the provider methods would never be called directly, but only via |
Its not a final close so you change the interface of the actual and therefor it is breaking |
If I make the methods static I won't be able to use |
You can use string interpolation. |
Looks good to me. |
Thanks! |
This PR fixes the greek phone numbers, because the existing phone numbers are not valid according to
libphonenumber
.I've used the data from Wikipedia and the regular expressions from
giggsey/libphonenumber-for-php
to generate valid greek numbers.The tests are not extensive but I ran them 10000 times using
phpunit test/Faker/Provider/el_GR/PhoneNumberTest.php --repeat 10000
and they all pass.