Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use symfony/phpunit-bridge #163

Merged
merged 2 commits into from
Dec 20, 2020
Merged

Use symfony/phpunit-bridge #163

merged 2 commits into from
Dec 20, 2020

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Dec 20, 2020

This might seam unnecessary. However, I believe it will be a great additions.

  1. The tests in Added helper class for extension #162 is failing on php 7.1 because the PHPUnit 7.5 does not include some methods. We worked our way around this by implementing an abstract TestCase ourselves.
  2. Our abstract TestCase always loads (soon to be legacy) providers and instantiating a new Generator. That is not required for most tests. See Added helper class for extension #162, [Modifiers] Helper methods to use our custom generators #155 and Adding support for extensions and PSR-11 #154
  3. We will soon start to deprecate methods. The symfony/phpunit-bridge will make sure we are not using deprecated code internally.
  4. We can probably start to use features in PHPUnit 10 that will be released in a few months.

And also, this is a dev dependency, so it does not really impact the project negatively.

@pimjansen pimjansen merged commit 62c1267 into FakerPHP:main Dec 20, 2020
@Nyholm
Copy link
Member Author

Nyholm commented Dec 20, 2020

Thank you for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants