Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use valid area codes for North America E164 phone numbers #280

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Use valid area codes for North America E164 phone numbers #280

merged 1 commit into from
Feb 19, 2021

Conversation

cmorbitzer
Copy link

@cmorbitzer cmorbitzer commented Feb 19, 2021

What is the reason for this PR?

  • A new feature
  • Fixed an issue (no issue ticket)

Author's checklist

Summary of changes

This builds on #261 and #264 to ensure that North American (en_US) E.164 phone numbers have valid area codes. Currently, generated E.164 phone numbers for the en_US locale can still be invalid without this change.

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

@pimjansen pimjansen added the bug Something isn't working label Feb 19, 2021
@pimjansen pimjansen merged commit 521b389 into FakerPHP:main Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants