Don't generate birth number of '000' for Swedish personal identity number

[pelmered]

What is the reason for this PR?

• A new feature
• Fixed an issue (resolve Birth numbers of '000' is not valid for Swedish personal identity number #305)

Author's checklist

• Follow the Contribution Guide
• New features and changes are documented

Summary of changes

Swedish personal identity number with a birth number of 000 is not valid. The birth number is the first 3 numbers of the last 4, marked with X here 19900101-XXX0

Note: There are no tests for this. I'm not sure how to test this in a good way as this only happen one time in 1000 on average. Any suggestions for this, or can we skip the test?

Review checklist

• All checks have passed
• Changes are approved by maintainer

[pimjansen]

Missing tests for this

[bram-pkg]

@pelmered this looks fine once you add the early return mentioned in @powellblyth's reply.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions.

[pelmered]

@bramceulemans
Updated the code now with early returns as requested.
However, I think the code is considerable less readable now than it was before with the else statement.

[pimjansen]

@bramceulemans

Updated the code now with early returns as requested.

However, I think the code is considerable less readable now than it was before with the else statement.

Still a small change requested. For the rest it looks fine for me

[bram-pkg]

If statements should be type-safe.

[bram-pkg]

LGTM! Thanks for the effort of improving this PR.

[bram-pkg]

@pimjansen what do you think about the suggestions from php-cs-fixer?

[pimjansen]

@pimjansen what do you think about the suggestions from php-cs-fixer?

Well not really an opinion though. There are pro and cons for both. But we have the fixer so lets follow it.

[bram-pkg]

Thanks for the quick fix.

[pelmered]

Thanks for the merge!