Improve type hints in UniqueGenerator #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This accomplishes: - Clarifies the intent of the code - Aids autocompletion - Aids static analysis tools
|
Valid but it is a breaking change by typing the constructor |
|
Thanks! |
pimjansen
reviewed
Jul 8, 2021
pimjansen
approved these changes
Jul 14, 2021
|
Thanks! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
With version 1.15.0 of Faker, PHPStan started showing static analysis issues related to the usage of
unique().Author's checklist
[ ] New features and changes are documentedSummary of changes
Review checklist