Ensure php 8.1 compatibility #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is good for future proofing. |
chris-doehring
changed the title
chris-doehring
commented
Sep 10, 2021
GrahamCampbell
previously requested changes
Sep 10, 2021
|
@GrahamCampbell Changed, thanks! :) |
bram-pkg
approved these changes
Sep 13, 2021
bram-pkg
dismissed
GrahamCampbell’s stale review
Requested changes have been applied.
GrahamCampbell
previously requested changes
Sep 13, 2021
|
Hey all. Is there anything I can help to do to get this PR moving? PHP 8.1 release date is approaching and atm this is blocking Laravel from offering full PHP 8.1 support. Let me know how I can help! |
|
Dries, I think this is actually done now. @GrahamCampbell just needs to approve the applied changes after his request. |
|
Thanks guys :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
phpspec/prophecyhas released version1.14.0today, which now allows to use the latest tagged phpunit under php 8.1.Author's checklist
Summary of changes
I have added php 8.1 to the test workflow to test new changes with php 8.1 in the future to ensure compatibility. I had to fix some deprecations though in order for phpunit to run successfully.
Review checklist