Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Payment Provider for ne_NP #375

Merged
merged 16 commits into from
Oct 2, 2021
Merged

Support Payment Provider for ne_NP #375

merged 16 commits into from
Oct 2, 2021

Conversation

remotemerge
Copy link

@remotemerge remotemerge commented Sep 11, 2021 •
edited
Loading

What is the reason for this PR?

This PR supports the Payment provider for the ne_NP locale.

  • Get financial institutions name
  • Get Bank Swift Code
  • Get bank account number

Author's checklist

Summary of changes

The Payment.php and PaymentTest.php are new files for the ne_NP locale.

Review checklist

  • All checks have passed
  • Changes are approved by the maintainer

pimjansen
pimjansen requested changes Sep 13, 2021
View reviewed changes
Copy link

@pimjansen pimjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall nice addition but needs some small work. Can you also ensure that for all data additions the source is added?

src/Faker/Provider/ne_NP/Payment.php Outdated Show resolved Hide resolved
src/Faker/Provider/ne_NP/Payment.php Outdated Show resolved Hide resolved
src/Faker/Provider/ne_NP/Payment.php Outdated Show resolved Hide resolved
src/Faker/Provider/ne_NP/Payment.php Outdated Show resolved Hide resolved
src/Faker/Provider/ne_NP/Payment.php Outdated Show resolved Hide resolved
src/Faker/Provider/ne_NP/Payment.php Outdated Show resolved Hide resolved
src/Faker/Provider/ne_NP/Payment.php Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Sep 29, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions.

@remotemerge
Copy link
Author

remotemerge commented Sep 29, 2021 •
edited
Loading

@bram-pkg @pimjansen, it's time to review :)

@stale stale bot removed the lifecycle/stale label Sep 29, 2021
@bram-pkg bram-pkg added the enhancement New feature or request label Sep 30, 2021
bram-pkg
bram-pkg approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@bram-pkg bram-pkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now!

@bram-pkg bram-pkg removed the request for review from pimjansen September 30, 2021 08:00
@remotemerge remotemerge requested a review from pimjansen October 1, 2021 14:04
@pimjansen pimjansen merged commit cc1a1a6 into FakerPHP:main Oct 2, 2021
@pimjansen
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bram-pkg bram-pkg bram-pkg approved these changes

@pimjansen pimjansen pimjansen approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remotemerge @pimjansen @bram-pkg