Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release of 1.11.0 #49

Merged
merged 4 commits into from
Nov 15, 2020
Merged

Prepare release of 1.11.0 #49

merged 4 commits into from
Nov 15, 2020

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Nov 14, 2020

The diff from 1.10.1 to main is quite large because of the CS changes.

I suggest a new release so future diffs are easier to read. Current main also have some features in it.

See diff without code style changes: v1.10.1...16f051e

@GrahamCampbell
Copy link
Member

Kinda early for a release. Shouldn't we fix more of the issues detected by the static analyzers first?

@Nyholm
Copy link
Member Author

Nyholm commented Nov 14, 2020

It is never too early =)

It has been almost a month, there has been no issues reported.

We will not run out of version numbers =)

@pimjansen
Copy link

I agree it would be good to push a new version even though it is mostly styling and such. Will keep it clean for future versions as well

@GrahamCampbell
Copy link
Member

Shouldn't this PR be deleting those entries from the BC config?

@GrahamCampbell
Copy link
Member

Hmm, I guess we want a green build for the tag though.

@Nyholm
Copy link
Member Author

Nyholm commented Nov 15, 2020

Correct. We can update the BC config file after the minor release.

@Nyholm
Copy link
Member Author

Nyholm commented Nov 15, 2020

We should release this after #53

@pimjansen
Copy link

I agree to push this but maybe extend the changelog a little on stuff that actually changed as well?

Like splitting the docs, psr12 compliance etc

@Nyholm
Copy link
Member Author

Nyholm commented Nov 15, 2020

In my mind, only code related changes should be in the change log.

I'll add a note about the code style

CHANGELOG.md Show resolved Hide resolved
@Nyholm Nyholm merged commit f228dc5 into FakerPHP:main Nov 15, 2020
@Nyholm Nyholm deleted the release-1.11.0 branch November 15, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants