Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider for Lithuanian municipalities #58

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

norkunas
Copy link

This PR:

  • Adds a new feature ...
  • Covered by tests
  • Fixes #nnnn

src/Faker/Provider/lt_LT/Municipality.php Outdated Show resolved Hide resolved
src/Faker/Provider/lt_LT/Municipality.php Outdated Show resolved Hide resolved
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

public function testMunicipality()
{
$result = $this->faker->municipality();
$this->assertStringEndsWith('savivaldybė', $result);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is pretty convenient =)

Copy link
Author

@norkunas norkunas Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 checked in your Sweden provider, i guess it's probably this way better to expect :)

@pimjansen pimjansen added the enhancement New feature or request label Nov 16, 2020
@pimjansen pimjansen merged commit 5ebae1b into FakerPHP:main Nov 16, 2020
@norkunas norkunas deleted the lt-municipalities branch November 16, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants