Feature/pl pl license plate #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IonBazan
reviewed
Nov 20, 2020
IonBazan
suggested changes
Nov 20, 2020
|
Thanks for feedback @IonBazan! All threads resolved. |
IonBazan
reviewed
Nov 22, 2020
|
Please rebase instead of merge. That keeps the history clean. |
Agree, you can always rebase and cleanuo your history which i prefer on this but anyway we will squash if needed in all other cases |
|
OK, thanks for the tip, I'm new to public PRs so appreciate all the feedback. |
bram-pkg
requested changes
Nov 24, 2020
There was a problem hiding this comment.
Please, can you also make a pull request to fakerphp.github.io for this Polish locale addition.
Sure! |
scybulski
force-pushed
the
feature/pl-pl-license-plate
branch
2 times, most recently
from
0613261 to
66877cb
Compare
scybulski
force-pushed
the
feature/pl-pl-license-plate
branch
from
66877cb to
7d5f228
Compare
|
PR to the documentation: FakerPHP/fakerphp.github.io#13 |
bram-pkg
approved these changes
Nov 25, 2020
IonBazan
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
It tries to follow variety of possible registration numbers used in Poland.
It also allows to generate numbers only for specific voivodeships or counties as well as for cars of services like Police, Tax Service or Counterintelligence Service.
PR was originally opened here. It didn't get fully reviewed but got some positive feedback.