-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated Polish data #70
Conversation
Thanks for your contribution, can you provide a source of your changes please. @IonBazan, can you maybe check this as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay but please provide an updated source for Macedonia name change and for cities list - I was not able to find it on Poczta-Polska website.
@@ -80,7 +80,7 @@ class Address extends \Faker\Provider\Address | |||
'Pruszcz Gdański','Pruszków','Przemyśl','Przędzel','Pszczyna','Puławy','Pułtusk','Racibórz', | |||
'Radom','Radomsko','Ruda Śląska','Rumia','Rybnik','Rynarzewo','Rzeszów','Sandomierz','Sanok', | |||
'Siedlce','Siemianowice Śląskie','Sieradz','Skalbmierz','Skarżysko-Kamienna','Skierniewice', | |||
'Słupsk','Sochaczew','Sopot','Sosnowiec','Stalowa Wola','Starachowice','Stargard Szczeciński', | |||
'Słupsk','Sochaczew','Sopot','Sosnowiec','Stalowa Wola','Starachowice','Stargard', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed, city name changed in 2015.
For banks I've used the same link @IonBazan used 3 years ago. The link is in the code so I've just updated the data. |
I agree, let's stick to the international standards.
…On Fri, Nov 27, 2020, 16:22 Pim Jansen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/Faker/Provider/pl_PL/Address.php
<#70 (comment)>:
> @@ -37,7 +37,7 @@ class Address extends \Faker\Provider\Address
'Jamajka', 'Japonia', 'Jemen', 'Jordania', 'Kambodża', 'Kamerun', 'Kanada', 'Katar', 'Kazachstan', 'Kenia',
'Kirgistan', 'Kiribati', 'Kolumbia', 'Komory', 'Kongo', 'Korea Południowa', 'Korea Północna', 'Kostaryka',
'Kuba', 'Kuwejt', 'Laos', 'Lesotho', 'Liban', 'Liberia', 'Libia', 'Liechtenstein', 'Litwa', 'Luksemburg',
- 'Łotwa', 'Macedonia', 'Madagaskar', 'Malawi', 'Malediwy', 'Malezja', 'Mali', 'Malta', 'Maroko', 'Mauretania',
+ 'Łotwa', 'Macedonia Północna', 'Madagaskar', 'Malawi', 'Malediwy', 'Malezja', 'Mali', 'Malta', 'Maroko', 'Mauretania',
I want to follow the ISO here though since we do not want to end up in
political stuff
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#70 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADFQHIY7GYSVAYSZWLTZCSDSR67ZVANCNFSM4UC67V4Q>
.
|
@@ -9,72 +9,73 @@ class Payment extends \Faker\Provider\Payment | |||
*/ | |||
protected static $banks = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a source for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, look into PHPDoc above. I've just updated the data from this source.
This PR: