Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated Polish data #70

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Conversation

scybulski
Copy link

This PR:

  • Updates some Polish data.

@bram-pkg
Copy link
Member

Thanks for your contribution, can you provide a source of your changes please. @IonBazan, can you maybe check this as well?

Copy link

@IonBazan IonBazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay but please provide an updated source for Macedonia name change and for cities list - I was not able to find it on Poczta-Polska website.

@@ -80,7 +80,7 @@ class Address extends \Faker\Provider\Address
'Pruszcz Gdański','Pruszków','Przemyśl','Przędzel','Pszczyna','Puławy','Pułtusk','Racibórz',
'Radom','Radomsko','Ruda Śląska','Rumia','Rybnik','Rynarzewo','Rzeszów','Sandomierz','Sanok',
'Siedlce','Siemianowice Śląskie','Sieradz','Skalbmierz','Skarżysko-Kamienna','Skierniewice',
'Słupsk','Sochaczew','Sopot','Sosnowiec','Stalowa Wola','Starachowice','Stargard Szczeciński',
'Słupsk','Sochaczew','Sopot','Sosnowiec','Stalowa Wola','Starachowice','Stargard',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, city name changed in 2015.

src/Faker/Provider/pl_PL/Address.php Show resolved Hide resolved
@scybulski
Copy link
Author

For banks I've used the same link @IonBazan used 3 years ago. The link is in the code so I've just updated the data.

@pimjansen pimjansen added the enhancement New feature or request label Nov 26, 2020
@bram-pkg
Copy link
Member

bram-pkg commented Nov 27, 2020 via email

@@ -9,72 +9,73 @@ class Payment extends \Faker\Provider\Payment
*/
protected static $banks = [

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a source for this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, look into PHPDoc above. I've just updated the data from this source.

@pimjansen pimjansen merged commit ce7751e into FakerPHP:main Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants