Deprecate at_AT providers #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
previously requested changes
Nov 28, 2020
bram-pkg
force-pushed
the
deprecate-at_AT
branch
from
3a921b4 to
d54d16a
Compare
pimjansen
approved these changes
Nov 28, 2020
|
Lgtm |
bram-pkg
requested review from
pimjansen
and removed request for
Nyholm and
GrahamCampbell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
at_ATis a non-existing locale. A backwards compatible change has been made to move away from this provider.In my opinion the next step is to deprecate
at_AT. This could be a patch release, since it's a backwards compatible bugfix.Next step is to update the docs accordingly and preferably mention
de_ATinstead ofat_AT.