Move US phone numbers with extension to own method #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Schmelz <daniel@schmelz.org>
bram-pkg
approved these changes
Dec 1, 2020
Signed-off-by: Daniel Schmelz <daniel@schmelz.org>
Merged
|
Hurrah! Thank you! Time to update half a dozen projects 😽 |
|
I mean, it hasn't been released yet. Unless you're running on the main branch from Git. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
phoneNumber()now only returns numbers without extension. Numbers with extension can now be generated withphoneNumberWithExtension()Even though it definitely appears to be a thing, I could not find an authoritative source that mentions the usage of x to signify extensions, thus no
@linksource reference in the docblock.