Merge pull request #405 from FalkorDB/settingsConfig

Settings config

app/settings/Configurations.tsx

@@ -197,8 +197,8 @@ export default function Configurations() {
                 <TableBody>
                     {
                         configs.map(({ name, description, value }, index) => (
-                            <TableRow key={name} className={cn("border-none", !(index % 2) && "bg-[#57577B]")}>
-                                <TableCell className="py-8">{name}</TableCell>
+                            <TableRow key={name} data-id={name} className={cn("border-none", !(index % 2) && "bg-[#57577B] hover:bg-[#57577B]")}>
+                                <TableCell className="w-[20%] py-8">{name}</TableCell>
                                 <TableCell className="w-[70%]">{description}</TableCell>
                                 <TableCell className="w-[15%]">
                                     {

e2e/config/roles.json

@@ -0,0 +1,13 @@
+{
+    "roles":{
+        "maxQueuedQueries": "MAX_QUEUED_QUERIES",
+        "TimeOut": "TIMEOUT",
+        "maxTimeOut":"TIMEOUT_MAX",
+        "defaultTimeOut":"TIMEOUT_DEFAULT",
+        "resultSetSize": "RESULTSET_SIZE",
+        "queryMemCapacity": "QUERY_MEM_CAPACITY",
+        "vKeyMaxEntityCount": "VKEY_MAX_ENTITY_COUNT",
+        "cmdInfo": "CMD_INFO",
+        "maxInfoQueries": "MAX_INFO_QUERIES"
+    }
+}

e2e/config/urls.json

@@ -2,7 +2,8 @@
     "api": {
         "addGraphUrl": "http://localhost:3000/api/graph/",
         "LoginApiUrl": "http://localhost:3000/api/auth/providers",
-        "deleteGraphUrl": "http://localhost:3000/api/graph/"
+        "deleteGraphUrl": "http://localhost:3000/api/graph/",
+        "settingsConfig": "http://localhost:3000/api/graph?config="
     },
 
     "falkorDBWeb": "https://www.falkordb.com/",

e2e/infra/api/apiRequests.ts

@@ -10,6 +10,16 @@ const getRequest = async (url: string, body: any, availableRequest?: APIRequestC
   const requestContext = availableRequest || (await request.newContext());
   return await requestContext.get(url, requestOptions);
 };
+
+const postRequest = async (url: string, body: any, availableRequest?: APIRequestContext, headers?: Record<string, string>) => {
+  const requestOptions = {
+    data: body,
+    headers: headers || undefined,
+  };
+
+  const requestContext = availableRequest || (await request.newContext());
+  return await requestContext.post(url, requestOptions);
+};
 
 const deleteRequest = async (url: string, headers?: Record<string, string>) => {
   const requestOptions = {
@@ -22,4 +32,4 @@ const deleteRequest = async (url: string, headers?: Record<string, string>) => {
 
 
 
-export{ getRequest, deleteRequest }
+export{ getRequest, deleteRequest, postRequest }

e2e/logic/POM/settingsConfigPage.ts

@@ -0,0 +1,13 @@
+import { Locator, Page } from "@playwright/test";
+import BasePage from "@/e2e/infra/ui/basePage";
+
+export default class SettingsConfigPage extends BasePage {
+
+    private get roleContentValue() : (role : string) => Locator {
+        return (role : string) => this.page.locator(`//tbody/tr[@data-id='${role}']/td/button/p`)
+    }
+
+    async getRoleContentValue(role : string): Promise<string | null>{
+        return await this.roleContentValue(role).textContent()
+    }   
+}

e2e/logic/api/apiCalls.ts

@@ -1,7 +1,8 @@
-import { deleteRequest, getRequest } from "../../infra/api/apiRequests";
+import { deleteRequest, getRequest, postRequest } from "../../infra/api/apiRequests";
 import urls from '../../config/urls.json'
 import { AddGraphResponse } from "./responses/addGraphResponse";
 import { RemoveGraphResponse } from "./responses/removeGraphResponse";
+import { ModifySettingsRoleResponse } from "./responses/modifySettingsRoleResponse";
 
 export class ApiCalls{
 
@@ -16,4 +17,10 @@ export class ApiCalls{
         const jsonData = await result.json();
         return jsonData
     }
+
+    async modifySettingsRole(roleName: string, roleValue : string, data? :any): Promise<ModifySettingsRoleResponse>{
+        const result = await postRequest(urls.api.settingsConfig + roleName + "&value=" + roleValue, data)
+        const jsonData = await result.json();
+        return jsonData
+    }
 }

e2e/logic/api/responses/modifySettingsRoleResponse.ts

@@ -0,0 +1,3 @@
+export interface ModifySettingsRoleResponse {
+    config: string;
+  }

e2e/tests/settingsConfig.spec.ts

@@ -0,0 +1,37 @@
+import { expect, test } from "@playwright/test";
+import urls  from '../config/urls.json'
+import { roles } from '../config/roles.json'
+import  BrowserWrapper  from "../infra/ui/browserWrapper";
+import SettingsConfigPage from "../logic/POM/settingsConfigPage";
+import { ApiCalls } from "../logic/api/apiCalls";
+
+test.describe('Settings Tests', () => {
+    let browser : BrowserWrapper;
+
+    test.beforeAll(async () => {
+        browser = new BrowserWrapper();
+    })
+
+    test.afterAll(async () => {
+        await browser.closeBrowser();
+    })
+
+    const inputData = [
+        { input: 'aa', description: "invalid input - character", expected: false},
+        { input: "-3", description: "invalid input - negative number", expected: false},
+        { input: "0", description: "invalid input - zero value", expected: false},
+        { input: "12", description: "without lowercase letters", expected: true},
+
+    ];
+
+    inputData.forEach(({ input, description, expected }) => {
+        test(`Modify ${roles.maxQueuedQueries} via API validation via UI: Input value: ${input} description: ${description}`, async () => {
+            const settingsConfigPage = await browser.createNewPage(SettingsConfigPage, urls.settingsUrl)
+            const apiCall = new ApiCalls()
+            await apiCall.modifySettingsRole(roles.maxQueuedQueries, input)
+            await settingsConfigPage.refreshPage()
+            const value = await settingsConfigPage.getRoleContentValue(roles.maxQueuedQueries)      
+            expect(value === input).toBe(expected)
+        });
+    })
+})