add pending status

[dudizimber]

fix #134

Summary by CodeRabbit

• New Features
  • Enhanced upgrade process feedback with a new status check for "PENDING," providing users with clearer updates during upgrades.
• Bug Fixes
  • Improved handling of the upgrade status to ensure users are informed when an upgrade is pending.

[coderabbitai]

Walkthrough

The changes introduce a new conditional check in the _wait_until_upgrade_ready function to handle the "PENDING" status of an upgrade process. When the status is "PENDING," the function logs an informational message, pauses for 10 seconds, and then logs another message indicating it is waiting for the instance to be ready. This enhancement complements the existing handling of the "IN_PROGRESS" status, which remains unchanged.

Changes

Files	Change Summary
omnistrate_tests/classes/omnistrate_fleet_instance.py	Added handling for the "PENDING" status in _wait_until_upgrade_ready, including logging and pauses.

Poem

In the land of upgrades, so bright and grand,
A rabbit hops lightly, with a pause and a stand.
"Pending," it whispers, "let's wait and see,
For soon we'll be ready, just you wait for me!"
With logs that keep track, and patience in tow,
The upgrades will flourish, as we watch them grow! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

omnistrate_tests/classes/omnistrate_fleet_instance.py (1)

439-443: LGTM with a minor suggestion.

The addition of the "PENDING" status handling is a good improvement to the upgrade process monitoring. It provides more granular status updates and maintains consistency with the existing code structure.

Consider adjusting the indentation of the "IN_PROGRESS" block to maintain the correct control flow:

 if status == "PENDING":
     logging.info("Upgrade pending")
     time.sleep(10)
     logging.info("Waiting for instance to be ready")
-if status == "IN_PROGRESS":
+elif status == "IN_PROGRESS":
     logging.info("Upgrade in progress")
     time.sleep(10)
     logging.info("Waiting for instance to be ready")

This change ensures that the "IN_PROGRESS" check is part of the same if-elif chain as the "PENDING" check, which appears to be the intended logic.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d93251d and 81b6f09.

Files selected for processing (1)

• omnistrate_tests/classes/omnistrate_fleet_instance.py (1 hunks)