Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

告示牌编辑防误触 #47

Closed
acaciachan opened this issue Nov 23, 2023 · 2 comments
Closed

告示牌编辑防误触 #47

acaciachan opened this issue Nov 23, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@acaciachan
Copy link

Motivation

0

Description

目前mojang做的告示牌逻辑非常坑：不打蜡的情况下是可以编辑的，但是只要右键一下就会点出编辑界面，而且打开编辑界面一旦输入了或者修改了文字，是无法撤销的，即使按Esc也会保存更改。这使得很多告示牌一旦被打开，就会多出一堆dsawasdwadsadaw等

解决办法：
1.只有在按下某些快捷键的情况下才能右键打开编辑
2.至少按Esc能不保存的退出编辑

Other information

No response
@Fallen-Breath Fallen-Breath added the enhancement New feature or request label Dec 13, 2023
Fallen-Breath added a commit that referenced this issue Dec 17, 2023
@Fallen-Breath
Added mc tweak signEditScreenCancelButton and `signEditScreenEscDis…
d152277 
…card`

for #47
Fallen-Breath added a commit that referenced this issue Dec 17, 2023
@Fallen-Breath
Added mc tweak signEditScreenCancelButton and `signEditScreenEscDis…
05f912e 
…card`

for #47
Fallen-Breath added a commit that referenced this issue Dec 17, 2023
@Fallen-Breath
Added mc tweak signEditScreenCancelButton and `signEditScreenEscDis…
19e6991 
…card`

for #47
Fallen-Breath added a commit that referenced this issue Dec 17, 2023
@Fallen-Breath
Added mc tweak signEditingRequiredHotkey
7c1c3e4 
for #47
@Fallen-Breath
Copy link
Owner

  1. 不好实现。打开告示牌编辑界面是服务端下发的，客户端不知道是什么触发了该打开告示牌编辑界面的操作。如果直接把全部情况都搞成需要快捷键，那么会放下告示牌的那一次编辑也会受影响
  2. 拆成 2 个需求：esc 不保存、额外的取消编辑丢弃修改的按钮

@Fallen-Breath
Copy link
Owner

esc 不保存、额外的取消编辑丢弃修改的按钮，这两个需求已在 v3.16.0 中实现

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fallen-Breath @acaciachan