keepMessage #58
Closed
keepMessage #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| restriction = @Restriction(require = @Condition(value = minecraft, versionPredicates = ">=1.20.4")), | ||
| category = Config.Category.PORTING | ||
| ) | ||
| public static final TweakerMoreConfigBoolean KEEP_MESSAGE = newConfigBoolean("keepMessage", false); |
There was a problem hiding this comment.
建议使用名字 keepMessageHistoryOnReconfiguration
| @Mixin(MinecraftClient.class) | ||
| public abstract class MinecraftClientMixin | ||
| { | ||
| @WrapWithCondition( |
There was a problem hiding this comment.
阻止整个 inGameHud 的 clear 可能会导致其他的副作用
| .: keepMessage | ||
| comment: |- | ||
| Keep your chat messages | ||
| With this option, When you use "/server", the client retains your chat message |
There was a problem hiding this comment.
请描述清楚功能用途。在原版语义下，/server 指令是不存在的指令
|
已于 c5713a3 实现 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#57
玩家使用
/server切换服务器时会进入配置阶段, 这个阶段会清除聊天记录使用
@WrapWithCondition将清除聊天记录代码包裹上if, 问题就解决了玩家disconnect的时候, 记录会正常清除
其他
于1.20.4测试正常