-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Rust Dependencies 2024-05-29 #226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Held back hyper, http, and yansi due to major changes
- Converted Paint::disable to Yansi::disable - Removed Windows specific code. Yansi now will try to enable on Windows and automatically disables if it can't activate.
- Added tests for create_date_diff, then updated deprecated calls and confirmed tests still passed
- Since the PR flow runs on UTC, updated the local PR script to also run UTC - Updated the create_date_diff test to validate UTC and print a warning to run UTC if it fails
tkmcmaster
changed the title
Update dependencies rust 2024-05-29
Update Rust Dependencies 2024-05-29
Jun 3, 2024
summersjc
approved these changes
Jun 3, 2024
Do you have some time to go over some of these changes? |
tkmcmaster
added a commit
that referenced
this pull request
Jun 3, 2024
* Moved deprecated .cargo/config to config.toml * Ignore clippy warning * Updated body_reader and channel dependencies * Updated config-wasm and hdr-histogram dependencies * Updated additional dependencies - Held back hyper, http, and yansi due to major changes * Updated Yansi to latest version - Converted Paint::disable to Yansi::disable - Removed Windows specific code. Yansi now will try to enable on Windows and automatically disables if it can't activate. * Added build test-server to the PR script and workflow * Fix dependency loop with ahash on itself - tkaitchuck/aHash#95 (comment) - rustwasm/wasm-bindgen#3031 (comment) * Updated yaml-rust to use yaml-rust2 due to deprecation - chyh1990/yaml-rust#197 - chyh1990/yaml-rust#160 (comment) * Updated cargo deny to remove deprecated entries - EmbarkStudios/cargo-deny#611 - https://embarkstudios.github.io/cargo-deny/checks/licenses/cfg.html#the-clarify-field-optional * Updated cargo lock file * Updated code for deprecations - Added tests for create_date_diff, then updated deprecated calls and confirmed tests still passed * Added clippy ignore large results and errors * Fixed tests to validate to UTC - Since the PR flow runs on UTC, updated the local PR script to also run UTC - Updated the create_date_diff test to validate UTC and print a warning to run UTC if it fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Updated Cargo dependencies. Resolved a circular dependency in ahash pulled in by using the feature
serde-serialize
inwasm-bindgen
. Removing the feature and then updatingwasm-bindgen
then fixes the issue. Also replaced the no longer maintainedyaml-rust
with the forkyaml-rust2
. Held back updatinghyper
andhttp
due to major breaking changes.ahash v0.7.4
depends on itself tkaitchuck/aHash#95 (comment)JsValue::from_serde
andJsValue::into_serde
rustwasm/wasm-bindgen#3031 (comment)