pewpew -d crash #99
Merged
pewpew -d crash #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new versions of Clap panic with invalid utf8 passed to value_of_os() - clap-rs/clap#3344
- Split the parsing code into separate functions that can be tested - Moved the logger init out of the match functions so we can test the cli parsing - Added tests around the path checks. Found we weren't parsing the try -d the same and fixed it
summersjc
approved these changes
Sep 9, 2022
jessica-yauney
approved these changes
Sep 9, 2022
- Unicode license is allowed under our current whitelist - Ignoring the time advisory since chrono should not be impacted. chronotope/chrono#602
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ddd8206