Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent legacy material initialization, update cloud, fix a few bugs related to 1.19.4 #119

Merged

Conversation

Grabsky
Copy link
Contributor

@Grabsky Grabsky commented May 31, 2024

Starting from PaperMC/Paper@ac554ad, this warning is appearing in the console:

[org.bukkit.craftbukkit.legacy.CraftLegacy] Initializing Legacy Material Support. Unless you have legacy plugins and/or data this is a bug!

While this should only affect versions 1.20.6 and higher, I changed this logic in all modules.

This PR also fixes /npc equipment command causing plugin loading failure on 1.19.4.

@Grabsky Grabsky marked this pull request as draft May 31, 2024 11:11
@Grabsky Grabsky changed the title fix initialization of legacy material support fix initialization of legacy material support (wip) May 31, 2024
@Grabsky Grabsky changed the title fix initialization of legacy material support (wip) prevent legacy material initialization, update cloud, fix a few bugs related to 1.19.4 May 31, 2024
@Grabsky Grabsky marked this pull request as ready for review May 31, 2024 15:34
@Grabsky
Copy link
Contributor Author

Grabsky commented May 31, 2024

Tested on 1.19.4 and 1.20.6.

@OliverSchlueter OliverSchlueter merged commit 1e9ffeb into FancyMcPlugins:main May 31, 2024
@Grabsky Grabsky deleted the fix-legacy-initialization branch June 2, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants