Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for formatted duration in wait action #183

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TheZexquex
Copy link

@TheZexquex TheZexquex commented Oct 20, 2024

Adds support for formatted durations to the "wait" npc action.
E.g

@OliverSchlueter
Copy link
Member

You basically copied the "general" command-methods and made them more specific for the wait action. If we now want to change something about lets say the add action command, we would need to modify two methods. Is there an better option for this? Maybe call the general method with the parsed values of the specific method?

@TheZexquex
Copy link
Author

I don't know if calling the original commmand method breaks something in cloud, but i'll try it. We could however at least extract the command logic to a seperat method and call it through both comman methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants