Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable pull request #57

Closed
FantasticFiasco opened this issue Jul 19, 2020 · 5 comments · Fixed by #64
Closed

Configurable pull request #57

FantasticFiasco opened this issue Jul 19, 2020 · 5 comments · Fixed by #64
Labels
enhancement New feature or request

Comments

@FantasticFiasco
Copy link
Owner

FantasticFiasco commented Jul 19, 2020 •
edited
Loading

It may be desired to configure pull request related properties, e.g.:

  • branchName - Might have to contain a variable for current year
  • commitMessage - The message of the commit
  • commitBody - The body of the commit
  • prTitle - Pull request title
  • prBody - Pull request body
  • assignees - Pull request assignees
  • labels - Pull request labels
@FantasticFiasco FantasticFiasco added the enhancement New feature or request label Jul 19, 2020
@tenshiAMD
Copy link

@FantasticFiasco you may want to add to those something like the configuration below:

  • paths - Repository paths for the LICENSE files (default: ./LICENSE)
  • prDescription - Pull request description (Note: Since I require PR description via mergeable)

@FantasticFiasco
Copy link
Owner Author

@tenshiAMD I'll add prDescription to the list and leave paths for #43.

I haven't heard about mergeable, is it this one?

@tenshiAMD
Copy link

@FantasticFiasco yeah that's the one I'm talking about

@tenshiAMD tenshiAMD mentioned this issue Jul 23, 2020
Closed
@FantasticFiasco FantasticFiasco mentioned this issue Jul 27, 2020
Merged
FantasticFiasco added a commit that referenced this issue Jul 27, 2020
@FantasticFiasco
feat: configure pull request
bfe1092 
Add support for configuring the pull request created by the action.

Closes #57
FantasticFiasco added a commit that referenced this issue Jul 28, 2020
@FantasticFiasco
feat: configure pull request
2138a68 
Add support for configuring the pull request created by the action.

Closes #57
FantasticFiasco added a commit that referenced this issue Jul 28, 2020
@FantasticFiasco
feat: configure pull request (#64)
26e9b9e 
Add support for configuring the pull request created by the action.

Closes #57
@FantasticFiasco
Copy link
Owner Author

This functionality is now released. A scenario in README.md highlights the changes.

Please get back to me if there is anything regarding PR configuration you would like.

@tenshiAMD
Copy link

@FantasticFiasco thanks a lot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Configure pull request FantasticFiasco/action-update-license-year
2 participants
@FantasticFiasco @tenshiAMD