-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility with NumPy 2.0 #535
Merged
pseudo-rnd-thoughts
merged 16 commits into
Farama-Foundation:master
from
pseudo-rnd-thoughts:obs_type=ram
Jul 23, 2024
Merged
Add compatibility with NumPy 2.0 #535
pseudo-rnd-thoughts
merged 16 commits into
Farama-Foundation:master
from
pseudo-rnd-thoughts:obs_type=ram
Jul 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pseudo-rnd-thoughts
changed the title
Add test for environment obs_type="ram"
Add compatibility to NumPy 2.0
Jun 28, 2024
This was referenced Jul 16, 2024
Closed
pseudo-rnd-thoughts
changed the title
Add compatibility to NumPy 2.0
Add compatibility with NumPy 2.0
Jul 23, 2024
pseudo-rnd-thoughts
merged commit Jul 23, 2024
4e5de3c
into
Farama-Foundation:master
28 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to using Pybind 2.10.0, this was incompatible with NumPy 2.0
This requires updating to pybind 2.12.0 however the CI broke at the same time due to an update with vcpkg
The fix was to use the same sha as the other CI to ensure they all used the same thing
Further updates the version number to 0.9.1