Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace conditions collection with dictionary #172

Merged

Conversation

luispfgarces
Copy link
Contributor

@luispfgarces luispfgarces commented Sep 6, 2024

Description

For performance reasons, this PR replaces the references:

  • IEnumerable<Condition<TCondition>> by IDictionary<TCondition, object>
  • IEnumerable<Condition<string>> by IDictionary<string, object>

Warning

BREAKING CHANGE: conditions are no longer accepted via a collection of Condition and a dictionary is accepted instead. As such, all calls to MatchOneAsync(...), MatchAllAsync(...), and SearchAsync(...) will need adjustment to provide a dictionary of conditions alternatively.

Change checklist

  • Code follows the code rules guidelines of this project
  • Commit messages follow the commit rules of this project
  • I have self-reviewed my changes before submitting this pull request
  • I have covered new/changed code with new tests and/or adjusted existent ones
  • I have made changes necessary to update the documentation accordingly

Please also check the I want to contribute guidelines and make sure you have done accordingly.

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@luispfgarces luispfgarces added this to the Release 3.0.0 milestone Sep 6, 2024
@luispfgarces luispfgarces force-pushed the replace_conditions_collection_with_dictionary branch from 5f1528c to c22446b Compare September 29, 2024 22:32
@luispfgarces luispfgarces force-pushed the replace_conditions_collection_with_dictionary branch from c22446b to ff89bc2 Compare October 5, 2024 18:34
@luispfgarces luispfgarces marked this pull request as ready for review October 5, 2024 18:47
@luispfgarces luispfgarces merged commit cf3b3c4 into release-3.0.0 Oct 8, 2024
1 check passed
@luispfgarces luispfgarces deleted the replace_conditions_collection_with_dictionary branch October 8, 2024 20:34
@luispfgarces luispfgarces mentioned this pull request Oct 8, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants