Replace conditions collection with dictionary #172
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For performance reasons, this PR replaces the references:
IEnumerable<Condition<TCondition>>
byIDictionary<TCondition, object>
IEnumerable<Condition<string>>
byIDictionary<string, object>
Warning
BREAKING CHANGE: conditions are no longer accepted via a collection of
Condition
and a dictionary is accepted instead. As such, all calls toMatchOneAsync(...)
,MatchAllAsync(...)
, andSearchAsync(...)
will need adjustment to provide a dictionary of conditions alternatively.Change checklist
Please also check the I want to contribute guidelines and make sure you have done accordingly.
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement