Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Remove union tool retain pieces option #1216

Merged
merged 3 commits into from
Nov 23, 2024

Conversation

DSCaskey
Copy link
Contributor

This PR removes the option to Retain orginal pieces in the Union Tool. Removing the option means the tool can't delete the pieces.

image

closes issue #1215

Copy link

what-the-diff bot commented Nov 19, 2024

🎉 Fantastic Pull Request Summary 🌈

We're absolutely thrilled to share these refreshing changes with you. Here's a nice friendly version of the technical stuff!

  • Language Simplification 🌎
    We've tidied up some translation entries related to the "Retain original pieces" feature in multiple languages (like Czech, German, Greek, English, Spanish, and others). This helps us maintain a cleaner and leaner codebase.

  • Polishing up union_dialog.cpp 🛠️
    We've waved goodbye to the retainPieces() method. And in the spirit of providing the most inviting code, we've renamed the checkPiece() to isPieceValid(). It's all about making things clear and understandable!

  • Interface Update for union_dialog.ui 🖥️
    Hang onto your hats! We have transformed the dialog's User Interface (UI) by removing the "Retain original pieces" checkbox. It's all part of our never-ending quest for a simpler, sleeker design!

Keep rocking guys! Each of your contributions brings us one step closer to our ultimate goals! Let's code for a better future, together. 🚀 🌍 💫

@DSCaskey DSCaskey merged commit 6d2e5af into develop Nov 23, 2024
10 checks passed
@DSCaskey DSCaskey deleted the remove-union-tool-delete-option branch November 23, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Remove the option to retain the original pieces in the Union tool
3 participants