Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed problem in StdDelegatingSerializer#serializeWithType where final serializer lookup was done on the pre-converted value when _delegateSerializer was null. #4749

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

k163377
Copy link
Contributor

@k163377 k163377 commented Oct 13, 2024

Since this was a minor bug fix, a PR has been issued to branch 2.18.


I discovered this problem while investigating the following issue
FasterXML/jackson-module-kotlin#819

Line 165 seemed to be set correctly.

Copy link
Member

@JooHyukKim JooHyukKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could u add ur work on the credits file?

@k163377
Copy link
Contributor Author

k163377 commented Oct 14, 2024

Thanks for the review, I pushed it.
970c3c4

Copy link
Member

@cowtowncoder cowtowncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It'd be of course great to have a test to verify the fix (and guard against regression), but the fix makes sense.

@cowtowncoder cowtowncoder merged commit 80e84c0 into FasterXML:2.18 Oct 14, 2024
9 checks passed
@k163377 k163377 deleted the find-ser branch October 14, 2024 04:07
@cowtowncoder
Copy link
Member

Merged; thank you @k163377 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants