Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #403: remove SmileBufferRecycler from 2.16 #404

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

cowtowncoder
Copy link
Member

So, alternate take to #399 where we just remove SmileBufferRecycler since it appears not to bring significant performance boost.

@cowtowncoder
Copy link
Member Author

Ok I think that for simplicity's sake, this makes more sense. Can reconsider in future if need be.

@cowtowncoder cowtowncoder merged commit 200ee04 into 2.16 Oct 4, 2023
3 checks passed
@cowtowncoder cowtowncoder deleted the tatu/2.16/403-rm-smile-recycling branch October 4, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant