Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create manifest files separately and reference in bundle plugin, THEN shade in the new manifest for Jakarta separately before install #136

Merged
merged 3 commits into from
Feb 23, 2021

Conversation

GedMarc
Copy link
Contributor

@GedMarc GedMarc commented Feb 22, 2021

Runs the bundle plugin twice, once for the creation of the original bundle, and again for the changes to the jakarta packing.
The manifest files are placed in target/jakarta and are picked up by the shading and replaces the javax manifest

#132

@GedMarc
Copy link
Contributor Author

GedMarc commented Feb 22, 2021

All updated and generated files attached

jackson-jaxrs-2.12.2-SNAPSHOT.zip

@@ -50,6 +50,9 @@ ${project.groupId}.annotation.*;version=${project.version}
<plugin>
<groupId>org.moditect</groupId>
<artifactId>moditect-maven-plugin</artifactId>
<configuration>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this to parent pom, so should not be needed here (at least seemed to work when I tried)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasn't placing in the META-INF/vesrions folder :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmh. Seemed to, for me, but I can double-check after merging.

pom.xml Show resolved Hide resolved
pom.xml Show resolved Hide resolved
@cowtowncoder
Copy link
Member

Looks good: the only tangible question is whether "jvm11" setting has to be on child poms and not on parent one? (I changed that recently and parent setting seemed to work).

@cowtowncoder cowtowncoder merged commit b30d5a9 into FasterXML:2.12 Feb 23, 2021
@cowtowncoder cowtowncoder modified the milestones: 2,3,, 2.12.2 Feb 23, 2021
@cowtowncoder
Copy link
Member

Oh bloody hell.

I think this royally messed up release process and resulted in corrupt 2.12.2 release :-(

So we get this:

 https://repo.maven.apache.org/maven2/com/fasterxml/jackson/jaxrs/jackson-jaxrs-json-provider/2.12.2/

where there somehow is ".pom.asc" but no actual ".pom" entry. Not sure how/why Sonatype Nexus accepts that; nor how it ends up, but that is consistent behavior.

Any chance this is due to that 0.0.1 version of a plugin?

@GedMarc
Copy link
Contributor Author

GedMarc commented Mar 4, 2021

Oh I don't think that is the case - We use the same in the primefaces release, and I deploy quite a lot through -

The asc is the signing piece right, the gpg file signatures? I got a few fails yesterday on the sonar deploys wondering if it's there or otherwise (https://jwebmp.com/teamcity)

@cowtowncoder
Copy link
Member

cowtowncoder commented Mar 4, 2021

It just seems very weird that only artifacts that use the post-processing failed; and that I have not observed these before. Will try to test locally when I have time today.

At the same time, JAX-RS repo is the very last thing pushed so that could be related to unlucky timing.
JSR-353 datatype (or jackson-datatypes-misc) was the 2nd to last repo...

And yes, .asc I think is the signature... so it'd have to be done based on existing file wouldn't it?

@cowtowncoder
Copy link
Member

@GedMarc Release plug-in pushes broken content reliably: I can see missing ".pom" after re-attempting 2.12.2 release. Odd part is that console has:

    [INFO]  * Connected to Nexus at https://oss.sonatype.org:443/, is version 2.14.20-02 and edition "Professional"
    [INFO]  * Using staging profile ID "b34f19b9cc6224" (configured by user).
    [INFO] Installing /Users/tatu/jackson/jackson-jaxrs-providers/target/checkout/yaml/target/jackson-jaxrs-yaml-provider-2.12.2.jar to /Users/tatu/jackson/jackson-jaxrs-providers/target/checkout/target/nexus-staging/staging/b34f19b9cc6224/com/fasterxml/jackson/jaxrs/jackson-jaxrs-yaml-provider/2.12.2/jackson-jaxrs-yaml-provider-2.12.2.jar
    [INFO] Installing /Users/tatu/jackson/jackson-jaxrs-providers/target/checkout/yaml/pom.xml to /Users/tatu/jackson/jackson-jaxrs-providers/target/checkout/target/nexus-staging/staging/b34f19b9cc6224/com/fasterxml/jackson/jaxrs/jackson-jaxrs-yaml-provider/2.12.2/jackson-jaxrs-yaml-provider-2.12.2.pom
    [INFO] Installing /Users/tatu/jackson/jackson-jaxrs-providers/target/checkout/yaml/target/jackson-jaxrs-yaml-provider-2.12.2.jar to /Users/tatu/jackson/jackson-jaxrs-providers/target/checkout/target/nexus-staging/staging/b34f19b9cc6224/com/fasterxml/jackson/jaxrs/jackson-jaxrs-yaml-provider/2.12.2/jackson-jaxrs-yaml-provider-2.12.2.jar
    [INFO] Installing /Users/tatu/jackson/jackson-jaxrs-providers/target/checkout/yaml/target/jackson-jaxrs-yaml-provider-2.12.2-jakarta.jar to /Users/tatu/jackson/jackson-jaxrs-providers/target/checkout/target/nexus-staging/staging/b34f19b9cc6224/com/fasterxml/jackson/jaxrs/jackson-jaxrs-yaml-provider/2.12.2/jackson-jaxrs-yaml-provider-2.12.2-jakarta.jar
    [INFO] Installing /Users/tatu/jackson/jackson-jaxrs-providers/target/checkout/yaml/target/jackson-jaxrs-yaml-provider-2.12.2-no-metainf-services.jar to /Users/tatu/jackson/jackson-jaxrs-providers/target/checkout/target/nexus-staging/staging/b34f19b9cc6224/com/fasterxml/jackson/jaxrs/jackson-jaxrs-yaml-provider/2.12.2/jackson-jaxrs-yaml-provider-2.12.2-no-metainf-services.jar
    [INFO] Installing /Users/tatu/jackson/jackson-jaxrs-providers/target/checkout/yaml/target/jackson-jaxrs-yaml-provider-2.12.2-sources.jar to /Users/tatu/jackson/jackson-jaxrs-providers/target/checkout/target/nexus-staging/staging/b34f19b9cc6224/com/fasterxml/jackson/jaxrs/jackson-jaxrs-yaml-provider/2.12.2/jackson-jaxrs-yaml-provider-2.12.2-sources.jar
...

but UI does not show jackson-jaxrs-yaml-provider-2.12.2.pom, only jackson-jaxrs-yaml-provider-2.12.2.pom.asc.
I'll see if Sonatype admins can shed any light on this.

@GedMarc
Copy link
Contributor Author

GedMarc commented Mar 5, 2021

there is definitely a breakage on sonar i think - i'm starting to get it as well, even on snapshots

The thing is, why would it deploy properly to snapshot, and then fail into production - the release plugin would work the same, only the rules of the repo would affect?

But this has been happening now for 3 days, and i'm not using felix at all sigh
image

@cowtowncoder
Copy link
Member

Hmmh. That's not good... I filed this:

https://issues.sonatype.org/browse/MVNCENTRAL-6595

and hopefully Joel can shed some light on what's happening.

@cowtowncoder
Copy link
Member

Looks like release plug-in reliably and always uploads a set of artifacts that is missing .pom file; output contains nothing to indicate any problem (.pom files get created and uploaded seemingly just fine). So I am not sure there is anything sporadic about the problem -- I guess on plus side it can be repeated easily.

cowtowncoder added a commit that referenced this pull request Mar 11, 2021
Remove Jakarta bundle fix added in #136 to try to fix #138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants