Skip to content

Commit

Permalink
Merge pull request #179 from Fdawgs/chore/ci-and-dependabot
Browse files Browse the repository at this point in the history
Dependabot config
  • Loading branch information
Fdawgs authored Dec 28, 2020
2 parents ac3552b + b8aca23 commit 3430a91
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 7 deletions.
8 changes: 7 additions & 1 deletion .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
version: 2
updates:
- package-ecosystem: github-actions
directory: /
schedule:
interval: monthly
open-pull-requests-limit: 99

- package-ecosystem: npm
directory: "/"
directory: /
schedule:
interval: monthly
open-pull-requests-limit: 99
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ jobs:
run: yarn lint
- name: Run Prettier
run: yarn lint:prettier:ci
- name: Compile TypeScript Definition File
run: yarn tsc

unittests:
name: Unit Tests
Expand Down
4 changes: 0 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,6 @@ After cloning and installing all the dependencies, there are several commands av
- `yarn jest` - Runs Jest over all tests in src directory
- `yarn test` - Runs `yarn lint` and `yarn jest` together

### Production Workflow

- `yarn start` - Runs a production version. No live reload.

## Pull Request Checklist

Prior to submitting a pull request back to the main repository, please make sure you have completed the following steps:
Expand Down
2 changes: 1 addition & 1 deletion src/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export class Poppler {
* Useful for Linux users who have poppler-utils binaries already installed.
*/
constructor(binPath?: string | undefined);
popplerPath: string;
popplerPath: string | undefined;
/**
* @author Frazer Smith
* @description Embeds files (attachments) into a PDF file.
Expand Down
3 changes: 2 additions & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"compilerOptions": {
"declaration": true,
"emitDeclarationOnly": true,
"allowJs": true
"allowJs": true,
"strict": true
}
}

0 comments on commit 3430a91

Please sign in to comment.