Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve transition rule documentation #223

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

KronosTheLate
Copy link
Contributor

This PR adds a much more complicated example for defining transition rules, as well as significantly changing the wording.

The old documentation was not enough for me to understand how to define the rules, so this took some trial and error. I believe that the documentation in the PR would have made things more clear from the start.

This PR adds a much more complicated example for defining transition rules, as well as significantly changing the wording.

The old documentation was not enough for me to understand how to define the rules, so this took some trial and error. I believe that the documentation in the PR would have made things more clear from the start.
@KronosTheLate KronosTheLate changed the title Improve transition rules Improve transition rule documentation Jun 8, 2023
@FedeClaudi
Copy link
Owner

That's a great example, thank you.
I really appreciate this string of PRs, thanks for helping making Term better!

@FedeClaudi FedeClaudi merged commit ae84047 into FedeClaudi:master Jun 8, 2023
@KronosTheLate
Copy link
Contributor Author

KronosTheLate commented Jun 8, 2023

Hey, thank you. Term is awesome <3

Edit:
It is actually really encouraging to have these PRs reviewed and merged so quickly, and to get such positive feedback on them. So good on you for making this a project that is nice to contribute to ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants