Automated Validation Tool for Jsthermalcomfort Package Functions #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some tests are not passing, why? |
FedericoTartarini
approved these changes
Oct 30, 2024
FedericoTartarini
merged commit da76436
into
FedericoTartarini:main
2 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The automated validation tool for the Jsthermalcomfort package has been completed.
This update involves the rewriting of all 25 test functions.
A new comftest.js file has been added to store all dynamic URLs needed for the functions, implemented using the prefixURL + json method.
A new testUtils.js file has been created to store the loadTestData and shouldSkipTest functions. These two functions are encapsulated in testUtils.js and are called as needed to reduce code redundancy.