Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with L2projection of mixed grid #456

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Conversation

lijas
Copy link
Collaborator

@lijas lijas commented Jun 19, 2022

We were not using the local index to get the quadrature point data, so it was not working for arbitrary cellsets.

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2022

Codecov Report

Merging #456 (d58315a) into master (b46853e) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
- Coverage   91.50%   91.33%   -0.17%     
==========================================
  Files          22       22              
  Lines        3259     3405     +146     
==========================================
+ Hits         2982     3110     +128     
- Misses        277      295      +18     
Impacted Files Coverage Δ
src/L2_projection.jl 100.00% <100.00%> (ø)
src/Grid/grid.jl 85.66% <0.00%> (-3.62%) ⬇️
src/assembler.jl 98.34% <0.00%> (ø)
src/Grid/coloring.jl 92.30% <0.00%> (ø)
src/Dofs/ConstraintHandler.jl 92.34% <0.00%> (ø)
src/Dofs/DofHandler.jl 86.81% <0.00%> (+3.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b46853e...d58315a. Read the comment docs.

@kimauth
Copy link
Member

kimauth commented Jun 20, 2022

Lgtm. I did confuse myself with the fact that we call the vector of cell indices set while reviewing though, perhaps we should change that to something like cellindices or cellids.

@fredrikekre
Copy link
Member

I did confuse myself with the fact that we call the vector of cell indices set while reviewing though

Same!

@fredrikekre fredrikekre merged commit 512b838 into master Jun 20, 2022
@fredrikekre fredrikekre deleted the eb_fix_mixed_L2 branch June 20, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants