Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong docs: CellIterator, assemble! #467

Merged
merged 3 commits into from
Jul 18, 2022
Merged

Conversation

KnutAM
Copy link
Member

@KnutAM KnutAM commented Jul 16, 2022

grid=generate_grid(Quadrilateral, (20, 20));
dh=DofHandler(grid); push!(dh, :u, 2); close!(dh);
CellIterator(dh).current_cellid[]

gives 0
(Fixing my own mistakes, ref #414 )

Edit: Added another doc error I discovered for assemble!(g, edof, ge) and assemble!(K, edof, Ke)
I also suggest renaming edof here to dofs to be consistent with the other assemble! methods

@KnutAM KnutAM added the docs label Jul 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2022

Codecov Report

Merging #467 (34e2078) into master (a6a2503) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #467   +/-   ##
=======================================
  Coverage   91.34%   91.34%           
=======================================
  Files          22       22           
  Lines        3407     3407           
=======================================
  Hits         3112     3112           
  Misses        295      295           
Impacted Files Coverage Δ
src/iterators.jl 96.92% <ø> (ø)
src/assembler.jl 98.34% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6a2503...34e2078. Read the comment docs.

@KnutAM KnutAM changed the title Fix wrong statement about CellIterator Fix wrong docs: CellIterator, assemble! Jul 18, 2022
@fredrikekre fredrikekre merged commit 6ce534f into master Jul 18, 2022
@fredrikekre fredrikekre deleted the kam/fixdocmistake branch July 18, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants