Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug mode toggle #524

Merged
merged 8 commits into from
Oct 19, 2022
Merged

Debug mode toggle #524

merged 8 commits into from
Oct 19, 2022

Conversation

termi-official
Copy link
Member

@termi-official termi-official commented Oct 18, 2022

Thanks to @fredrikekre for showing this nice trick!

Open TODOs

  • Introduce actual toggle
  • Add to docs
  • Update changelog

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2022

Codecov Report

Base: 92.37% // Head: 92.20% // Decreases project coverage by -0.17% ⚠️

Coverage data is based on head (9facf7f) compared to base (084a7c9).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
- Coverage   92.37%   92.20%   -0.18%     
==========================================
  Files          22       22              
  Lines        3776     3783       +7     
==========================================
  Hits         3488     3488              
- Misses        288      295       +7     
Impacted Files Coverage Δ
src/utils.jl 36.36% <0.00%> (-63.64%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@termi-official termi-official marked this pull request as ready for review October 18, 2022 21:38
Project.toml Outdated Show resolved Hide resolved
src/utils.jl Outdated Show resolved Hide resolved
Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some small tweaks, thanks :)

docs/src/index.md Show resolved Hide resolved
@fredrikekre fredrikekre merged commit 59ecfeb into master Oct 19, 2022
@fredrikekre fredrikekre deleted the do/debug-option branch October 19, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants