Update VTK export to use CellValues for evalutation #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnutAM
reviewed
May 10, 2023
lijas
reviewed
May 11, 2023
This patch deprecates `reshape_to_nodes` in favor of the new `evaluate_at_grid_nodes` function which more or less does the same thing. `evaluate_at_grid_nodes` uses the interpolation of the field to evaluate the approximated function in the cell coordinates (by using `reference_coordinates` of the cell as quadrature points). This is much simpler, and more correct, compared to figuring out which Dofs live on which node etc. In particular, this now support non-standard interpolations which may not even have dofs in the nodes. Fixes #167.
fredrikekre
force-pushed
the
fe/export-by-celvlalues
branch
from
a8ac1c2
to
b240705
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #703 +/- ##
==========================================
+ Coverage 92.55% 92.62% +0.07%
==========================================
Files 30 30
Lines 4390 4422 +32
==========================================
+ Hits 4063 4096 +33
+ Misses 327 326 -1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch deprecates
reshape_to_nodesin favor of the newevaluate_at_grid_nodesfunction which more or less does the same thing.evaluate_at_grid_nodesuses the interpolation of the field to evaluate the approximated function in the cell coordinates (by usingreference_coordinatesof the cell as quadrature points). This is much simpler, and more correct, compared to figuring out which Dofs live on which node etc. In particular, this now support non-standard interpolations which may not even have dofs in the nodes.Fixes #167.