Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InterfaceValues for DG interface integration #743

Merged

Conversation

AbdAlazezAhmed
Copy link
Collaborator

@AbdAlazezAhmed AbdAlazezAhmed commented Jun 18, 2023

Tasks:

  • InterfaceValues
  • syncing/transforming quadrature points
  • docs
  • tests

After merge

  • open issue to discuss mixed grid support for InterfaceValues
  • check subdomain support and possibly open issue
  • open issue about the investigation of mortaring with the new infrastructure

@AbdAlazezAhmed AbdAlazezAhmed added feature gsoc23 Google Summer of Code 2023 labels Jun 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (d0f0e07) 92.98% compared to head (8e665d6) 93.08%.

Files Patch % Lines
src/FEValues/interface_values.jl 93.05% 10 Missing ⚠️
src/Grid/grid.jl 92.30% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #743      +/-   ##
==========================================
+ Coverage   92.98%   93.08%   +0.09%     
==========================================
  Files          33       34       +1     
  Lines        4950     5161     +211     
==========================================
+ Hits         4603     4804     +201     
- Misses        347      357      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@termi-official termi-official left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments. I think resolving these and the open ones and the PR should be good. We might want to leave mixed grids as future work.

src/FEValues/interface_values.jl Outdated Show resolved Hide resolved
src/FEValues/interface_values.jl Outdated Show resolved Hide resolved
src/FEValues/interface_values.jl Outdated Show resolved Hide resolved
src/FEValues/interface_values.jl Outdated Show resolved Hide resolved
src/FEValues/interface_values.jl Outdated Show resolved Hide resolved
src/FEValues/common_values.jl Outdated Show resolved Hide resolved
src/FEValues/interface_values.jl Outdated Show resolved Hide resolved
src/FEValues/interface_values.jl Outdated Show resolved Hide resolved
src/Grid/grid.jl Show resolved Hide resolved
test/test_utils.jl Outdated Show resolved Hide resolved
@termi-official
Copy link
Member

I guess it is only left to merge master and resolving #743 (comment)

@lijas
Copy link
Collaborator

lijas commented Nov 10, 2023

I was able to use a lot of stuff in the PR for implementing "GhostPenalty" with my IGA elements, so thats really nice :)

Only thing I noticed was that I had an really old verision of Tensors that did not include the functions rotation_tensor(::Float64, Float64, Float64). I did not get any error/warning from the package manager either. Does this mean that we should require Tensors to be >= v1.14.0 in the project file?

@AbdAlazezAhmed
Copy link
Collaborator Author

There were a custom rotation tensor function in this PR previously but I removed it in favor of not repeating stuff since we already have it in Tensors.jl
The difference is that it used ´sinpi´ and ´cospi´ which seem to be more accurate and pass the tests, while using ´sin´ and ´cos´ required increasing tolerance a bit.

@termi-official
Copy link
Member

Good catch @lijas . Can you bump the compat here and merge master @AbdAlazezAhmed ?

@fredrikekre do you have time for a final review from your side? I am happy with the state for now.:)

@termi-official termi-official added the awaiting review PR is finished from the authors POV, waiting for feedback label Nov 14, 2023
Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fredrikekre fredrikekre merged commit 8e37e81 into Ferrite-FEM:master Dec 3, 2023
6 checks passed
@fredrikekre
Copy link
Member

Great job :) Perhaps you can add an entry in the CHANGELOG?

@fredrikekre fredrikekre removed the awaiting review PR is finished from the authors POV, waiting for feedback label Dec 3, 2023
@AbdAlazezAhmed AbdAlazezAhmed deleted the face-integration-experiments branch December 6, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature gsoc23 Google Summer of Code 2023
Projects
Development

Successfully merging this pull request may close these issues.

7 participants