Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded MockFheOps, switch to a compilation of the user's fhenix-contracts version #9

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

architect-dev
Copy link
Contributor

Uses peerDependencies to use the user's installed fhenix-contracts version to prevent collision. Also shouldn't need to be updated in the future.

Copy link
Contributor

@eshelB eshelB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@architect-dev architect-dev merged commit 03311a3 into v0.2.x Oct 7, 2024
4 checks passed
@architect-dev architect-dev deleted the feature/remove-mock-hardcoding branch October 7, 2024 12:25
architect-dev added a commit that referenced this pull request Oct 7, 2024
…enix-contracts version (#9)

* Switch to dependency compilation from fhenix-contracts. Uses user's fhenix-contracts version

* Compile MockFheOps without external dependency, works within tests now

* Remove logs

* Fix linting issues

* Update hardhat version

* Try and fix this issue
architect-dev added a commit that referenced this pull request Oct 7, 2024
…enix-contracts version (#9)

* Switch to dependency compilation from fhenix-contracts. Uses user's fhenix-contracts version

* Compile MockFheOps without external dependency, works within tests now

* Remove logs

* Fix linting issues

* Update hardhat version

* Try and fix this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants