Fix logging #156
Merged
Fix logging #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Adding meaningful logger on init(), but I don't know if someone uses it...
liorbond
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed fheos logging. (which included contract logs but not only, it included all debugs!)
The problem was that when wrapping the handler with NewGlogHandler (are we using glog's functionality even?), there was a reset of the loglevel, for some reason, so I had to set it again with Verbosity.
Notes: there is also an
function init()in fheos which initialized a logger which is not really used I believe, because later we do initFheos and we override this logger. Maybe we can remove the init function.