-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: Get ct data #158
Open
eshelB
wants to merge
14
commits into
master
Choose a base branch
from
get-ct-data
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
wip: Get ct data #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or the new precompiled function on FHE.sol
Yeah, as you said this should be an RPC call, not a call that is done via solidity. What we'd want is to create some API in fheos that exposes the functionality and have the Nitro node add a new set of RPC functions (similar to web3/net/arbdebug/etc.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding precompiled function that gets a ciphertext's data by hash
Issue: the precompiled contract is probably not the owner of the ciphertext, which makes it impossible to get it from storage.
probably this should be done instead with an rpc call outside the evm. Otherwise ownership can be bypassed if another contract calls this method.
minor open question:
assuming we go forward, solving the ownership issue, do we need to return only the
.Data
field of the ct, or also the other metadata fields we store such ascompressed
,compact
,type
,triviallyEncrypted
,SecurityZone
, etc.? currently returning only data, but trivial to add the other fields.